Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade @fluentui/react to 8.x version #3546

Merged
merged 6 commits into from
May 10, 2023
Merged

Upgrade @fluentui/react to 8.x version #3546

merged 6 commits into from
May 10, 2023

Conversation

saip92
Copy link
Contributor

@saip92 saip92 commented Mar 27, 2023

Reasons for making this change

This PR updates @fluentui/react to use version 8.x

fixes #3463

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@heath-freenome
Copy link
Member

Also, once a PR to fix the playground is merged, I would love to see some screenshots of Fluent 8 in the playground

@heath-freenome
Copy link
Member

@saip92 Have you had a chance to look over my feedback?

@saip92
Copy link
Contributor Author

saip92 commented Mar 30, 2023

@heath-freenome Sorry. Haven't had a chance to work on them yet but will do later this week.

@heath-freenome
Copy link
Member

@saip92 I hope you'll have some time to deal with the conflicts as well.

@saip92 saip92 force-pushed the saip92/update-fluentui-to-v8 branch from 4d0315c to c8de484 Compare April 30, 2023 19:20
@saip92
Copy link
Contributor Author

saip92 commented Apr 30, 2023

@heath-freenome Sorry I couldn't get to this sooner! I've made the changes to address your feedback and resolved conflicts.

I do have a question about Fluent UI v9. This is a separate package @fluentui/react-components and has several major changes. Would this warrant having a separate theme implementation for the v9 version of Fluent UI?

@heath-freenome
Copy link
Member

@heath-freenome Sorry I couldn't get to this sooner! I've made the changes to address your feedback and resolved conflicts.

I do have a question about Fluent UI v9. This is a separate package @fluentui/react-components and has several major changes. Would this warrant having a separate theme implementation for the v9 version of Fluent UI?

If fluent 9 imports from a different place, then yes it would warrant a different theme. Just like material-ui and mui are different themes with about 99% the same code due to the imports changing.

heath-freenome
heath-freenome reviewed May 2, 2023
View reviewed changes
@saip92 saip92 force-pushed the saip92/update-fluentui-to-v8 branch from c8de484 to 94cd872 Compare May 10, 2023 00:36
heath-freenome
heath-freenome reviewed May 10, 2023
View reviewed changes
@saip92 saip92 force-pushed the saip92/update-fluentui-to-v8 branch from eee4c4a to c74987d Compare May 10, 2023 16:19
@heath-freenome heath-freenome merged commit c527317 into rjsf-team:main May 10, 2023
heath-freenome added a commit to heath-freenome/react-jsonschema-form that referenced this pull request May 10, 2023
@heath-freenome
- Fixed the peerDependencies in the fluent-ui package-lock.json and…
31b69af 
… improved the `CHANGELOG.md` comments related to rjsf-team#3546
heath-freenome added a commit that referenced this pull request May 11, 2023
@heath-freenome
fix: Implement precompiled validator support in @rjsf/validator-ajv8 (#…
91bcc94 
…3652)

* fix: Implement precompiled validator support in @rjsf/validator-ajv8
Fixes #3543 by implementing support for precompiled validators
- In `@rjsf/validator-ajv8` added support for precompiled validators as follows:
  - Added a new `compileSchemaValidators()` API function used to generate the precompiled validators for a schema to an output file
  - Updated the documentation for the `customizeValidator()` API function
  - Added a new `AJV8PrecompiledValidator` implementation of the `ValidatorType` interface
  - Refactored a large piece of the raw validation error processing from the `AJV8Validator` into a new `processRawValidationErrors()` function also used by the `AJV8PrecompiledValidator`
  - Added a new `usePrecompiledValidator()` API function that is similar to `customizeValidator()` but returning a precompiled validator-based `ValidatorType` interface implementation
  - Added some new types to the `types.ts` file in support of precompiled validators
  - Updated the main `index.ts` file to export the new types and API functions
  - Added 100% unit test coverage of the new feature
    - This included implementing a node function to precompile the `superSchema.json` file found in the `test/harness` directory
  - Added `ignorePatterns` to the `.eslintrc` file to ignore the precompiled schema files
- Updated the `validation.md` documentation for the new precompiled validator functionality
- Added a new `validator-ajv8.md` documentation file to the `api-reference` directory and the `sidebar.js`
- Updated the `CHANGELOG.md` file accordingly

* - Responded to self-review feedback

* - Replaced usage of `<` with `&lt;` to match the similar line later in the file

* - Fixed the peerDependencies in the `fluent-ui` package-lock.json and improved the `CHANGELOG.md` comments related to #3546

* - Responded to reviewer feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heath-freenome heath-freenome heath-freenome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade fluent ui version to version 8
2 participants
@saip92 @heath-freenome