fix: reimplement #1588 and #2816 #3435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: rjsf-team#2593 by reimplementing rjsf-team#2816. Also reimplemented the empty `anyOf`/`oneOf` handling of rjsf-team#1588 - In `@rjsf/utils`, reimplemented the `additionalProperties` handling logic of rjsf-team#2816 into `computeDefault()`, refactoring some common code into `maybeAddDefaultToObject()` - Also deal with empty `anyOf`/`oneOf` arrays by returning undefined, reimplementing rjsf-team#1588 - In `@rjsf/core`, added the `additionalProperties` tests from rjsf-team#2816 - Updated the `CHANGELOG.md` accordingly
This was referenced Feb 6, 2023
nickgros
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes: #2593 by reimplementing #2816. Also reimplemented the empty
anyOf/oneOfhandling of #1588@rjsf/utils, reimplemented theadditionalPropertieshandling logic of fix: additionalProperties defaults are not propagated to the form #2816 intocomputeDefault(), refactoring some common code intomaybeAddDefaultToObject()anyOf/oneOfarrays by returning undefined, reimplementing Fix anyof and oneof inside additional properties. #1588@rjsf/core, added theadditionalPropertiestests from fix: additionalProperties defaults are not propagated to the form #2816CHANGELOG.mdaccordinglyChecklist
npm run test:updateto update snapshots, if needed.