Fix: Chakra-ui SelectWidget to show proper selection #3429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heath-freenome
commented
Feb 3, 2023
| @@ -70,7 +71,7 @@ export default function SelectWidget< | |||
| ) | |||
| ? enumOptions.map((option: EnumOptionsType<S>, index: number) => { | |||
| const { value, label } = option; | |||
| _valueLabelMap[index] = label; | |||
| _valueLabelMap[index] = label || String(value); | |||
There was a problem hiding this comment.
If no label, fall-back to the stringified value (same as the code below, but better here)
nickgros
approved these changes
Feb 3, 2023
Fixes: rjsf-team#3422 by using the selected value for the single selection - Updated the `@rjsf/chakra-ui` `SelectWidget` to properly use the selected value rather than a hard-coded `0` value - Updated the `CHANGELOG.md` accordingly
ea3cd1f to
0dd3e1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes: #3422 by using the selected value for the single selection
@rjsf/chakra-uiSelectWidgetto properly use the selected value rather than a hard-coded0valueCHANGELOG.mdaccordinglyChecklist
npm run test:updateto update snapshots, if needed.