Fix: Revert part of fix for #1654 that was causing #3412 #3414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#3412 Fixes: rjsf-team#3412 by reverting the last change made to `getSchemaType()` The type inference from `anyOf`/`oneOf` that was added to fix rjsf-team#1654 actually caused a worse bug, and without it the inference now happens properly due to other fixes somehow - In `@rjsf/utils`, reverted the type inference from `anyOf`/`oneOf` - Updated the `CHANGELOG.md` accordingly
nickgros
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes: #3412 by reverting the last change made to
getSchemaType()The type inference from
anyOf/oneOfthat was added to fix #1654 actually caused a worse bug, and without it the inference now happens properly due to other fixes somehow@rjsf/utils, reverted the type inference fromanyOf/oneOfCHANGELOG.mdaccordinglyChecklist
npm run test:updateto update snapshots, if needed.