-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add generic type support to the bootstrap-4 theme #3326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heath-freenome
requested changes
Dec 29, 2022
packages/bootstrap-4/src/BaseInputTemplate/BaseInputTemplate.tsx
Outdated
Show resolved
Hide resolved
- Partially fix 3072
fa1135b
to
774e1c0
Compare
heath-freenome
approved these changes
Dec 30, 2022
heath-freenome
requested changes
Dec 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, you forgot to update the main index.ts
import Form from "./Form/Form";
export { default as Form, generateForm } from "./Form";
export { default as Templates, generateTemplates } from "./Templates";
export { default as Theme, generateTheme } from "./Theme";
export { default as Widgets, generateWidgets } from "./Widgets";
export default Form;
heath-freenome
approved these changes
Jan 4, 2023
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
* Generic support for Bootstrap 4 - Partially fix 3072 * Changes from code review * Changes from code review Co-authored-by: Heath C <51679588+heath-freenome@users.noreply.github.com>
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
* Generic support for Bootstrap 4 - Partially fix 3072 * Changes from code review * Changes from code review Co-authored-by: Heath C <51679588+heath-freenome@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3319, partial fix for #3072
Checklist
npm run test:update
to update snapshots, if needed.