Fix MUI/material-ui RangeWidget missing htmlFor and schema.title #3281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
The
RangeWidget
for both the Material UI v4 and v5 themes did not have thehtmlFor
prop, which may cause accessibility issues.Also I noticed that the other widgets included
schema.title
in theFormLabel
, so I went ahead and included that also just to ensure consistency with the other widgets'FormLabel
s. Also I don't think theid
prop is necessary either (it's not in the otherFormLabel
s either).I also searched both
@rjsf/mui
and@rjsf/material-ui
to make sure there was no otherFormLabel
components missing thehtmlFor
prop.RangeWidget
was the only one missing it. I also found no other components that were missing theschema.title
either.Checklist
npm run test:update
to update snapshots, if needed.