make Semantic-UI's AddButton not show an empty label #3142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
The Semantic-UI theme's AddButton, which is used for ObjectFieldTemplate and ArrayFieldTemplate, currently displays an empty slot for a non-existent label:


This makes it show a square button:
Checklist
npm run test:update
to update snapshots, if needed.I cannot run/update the tests as the build fails for me. I assume it's somehow a me issue though:the./templates.js
file is present innode_modules/chalk/
, but not inpackages/core/node_modules/@babel/highlight/node_modules/chalk/
(and all other dependencies depending on it). I'd appreciate guidance on this. Should I open a separate issue?EDIT: ignore the above. Deleting the
node_modules
folders and re-runningnpm install
fixed it. I assume thenode_modules
folders ended up in an invalid state after my first run ofnpm run build
failed.For the record, this is what I ran: