Properly pass formContext to SchemaField #3040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heath-freenome
commented
Aug 23, 2022
- Updated `ArrayField`, `MultiSchemaField`, `ObjectField` and `SchemaField` to pass `formContext` down the hierarchy properly - Updated tests to validate `formContext` is properly passed to `SchemaField` - Updated the `CHANGELOG.md` file with the fix mentioned
aee8f12 to
8654a61
Compare
heath-freenome
commented
Aug 24, 2022
jacqueswho
approved these changes
Aug 25, 2022
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Aug 27, 2022
* Properly pass formContext to SchemaField - Updated `ArrayField`, `MultiSchemaField`, `ObjectField` and `SchemaField` to pass `formContext` down the hierarchy properly - Updated tests to validate `formContext` is properly passed to `SchemaField` - Updated the `CHANGELOG.md` file with the fix mentioned * Update packages/core/test/allOf_test.js
This was referenced Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #2394, #2274
ArrayField,MultiSchemaField,ObjectFieldandSchemaFieldto passformContextdown the hierarchy properlyformContextis properly passed toSchemaFieldCHANGELOG.mdfile with the fix mentionedChecklist
npm run test:updateto update snapshots, if needed.