Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ui:emptyValue for SelectWidget #3026

Conversation

heath-freenome
Copy link
Member

Reasons for making this change

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

- This is a reimplementation of rjsf-team#2251
- Fixes rjsf-team#1041
Copy link
Contributor

@nickgros nickgros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending change to ternary

@heath-freenome heath-freenome merged commit 547526a into rjsf-team:rjsf-v5 Aug 19, 2022
@heath-freenome heath-freenome deleted the fix-SelectWidget-to-use-emptyValue branch August 19, 2022 16:48
heath-freenome added a commit to heath-freenome/react-jsonschema-form that referenced this pull request Aug 27, 2022
* Use ui:emptyValue for SelectWidget
- This is a reimplementation of rjsf-team#2251
- Fixes rjsf-team#1041

* - Added `processSelectValue()` to `fluent-ui` for single select

* - Fixed documentation for `emptyValue`

* - Responded to self-feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants