Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(semantic-ui): update main field #3022

Merged
merged 1 commit into from
Aug 19, 2022
Merged

fix(semantic-ui): update main field #3022

merged 1 commit into from
Aug 19, 2022

Conversation

bluwy
Copy link
Contributor

@bluwy bluwy commented Aug 17, 2022

Reasons for making this change

The main points to dist/cjs/index.js which doesn't exist. It should be dist/index.js

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@heath-freenome
Copy link
Member

@bluwy Good catch, would you be willing to rebase this change onto the rjsf-v5 branch as that branch will soon be merged to the master?

@bluwy bluwy changed the base branch from master to rjsf-v5 August 19, 2022 07:04
@bluwy
Copy link
Contributor Author

bluwy commented Aug 19, 2022

Done!

@heath-freenome heath-freenome merged commit 3c9454f into rjsf-team:rjsf-v5 Aug 19, 2022
@bluwy bluwy deleted the patch-1 branch August 20, 2022 02:46
heath-freenome pushed a commit to heath-freenome/react-jsonschema-form that referenced this pull request Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants