Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@rjsf-antd): Submit button type bug (#2867) #2869

Merged
merged 9 commits into from
May 25, 2022
Merged

fix(@rjsf-antd): Submit button type bug (#2867) #2869

Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
afdd34c
Submit button type bug fix
sarpere May 23, 2022
4729872
Submit button type bug fix
sarpere May 23, 2022
86bbc7d
Merge branch 'rjsf-antd-submit-bug' of https://github.com/sarpere/rea…
sarpere May 23, 2022
feccf46
Merge branch 'rjsf-antd-submit-bug' of https://github.com/sarpere/rea…
sarpere May 23, 2022
535fa5a
Merge branch 'rjsf-antd-submit-bug' of https://github.com/sarpere/rea…
sarpere May 23, 2022
9912e66
Revert "Submit button type bug fix"
sarpere May 23, 2022
7c68bfe
Submit button type fix
sarpere May 23, 2022
45db00c
White space removed
sarpere May 24, 2022
7edad15
antd test snapshots update
sarpere May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/antd/src/widgets/SubmitButton/SubmitButton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const { getSubmitButtonOptions } = utils;
export default ({ uiSchema }) => {
const { submitText, norender, props: submitButtonProps }= getSubmitButtonOptions(uiSchema);
if (norender) {return null;}
return (<Button type="submit" {...submitButtonProps}>
return (<Button htmlType="submit" {...submitButtonProps}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor little thing... there seems to be an extra space between Button and htmlType that you are welcome to remove even though it was there before

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all done. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It look like you are going to have to update the test snapshots as a result of this change

Copy link
Contributor Author

@sarpere sarpere May 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated snapshots. You can try to trigger workflow. I'm not getting test run bug.

{submitText}
</Button>);
};
Expand Down