-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly assign label prop for MultiSelect ArrayField #2459
Conversation
Why set it to "name" but not "title"? |
@epicfaace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I took another look and it's helpful to know that other LOCs in the same ArrayField.js have similar logic as const title = schema.title || name;
-- this makes it easier to understand how it works in context (and it's not adding anything new, rather just adding something that was missing earlier).
Reasons for making this change
Fixes #2378
@epicfaace @fsteger do you think this would be an appropriate solution?
Checklist