Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add option to change the AddButton's text via uiSchema #2348

Closed
wants to merge 8 commits into from

Conversation

ennoente
Copy link

@ennoente ennoente commented Apr 27, 2021

Reasons for making this change

This feature would add the option to set a ui:addButtonText field inside the uiSchema which will result in a custom text for the respective AddButton.
This would affect all packages except Bootstrap and core since they do not have any text on the AddButton in the first place.

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

Deploy preview

Once CI finishes, you should be able to view a deploy preview of the playground from this PR at this link: https://deploy-preview-[PR_NUMBER]--rjsf.netlify.app/

@ennoente
Copy link
Author

ennoente commented May 3, 2021

closes #2357

@heath-freenome
Copy link
Member

@ennoente Closing this as being fixed via the AddButton template added to the v5 beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants