Properly hide rows when ui:widget is hidden (bootstrap-4) #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #1683. |
epicfaace
reviewed
Dec 20, 2020
| @@ -33,7 +33,7 @@ const ObjectFieldTemplate = ({ | |||
| )} | |||
| <Container fluid className="p-0"> | |||
| {properties.map((element: any, index: number) => ( | |||
| <Row key={index} style={{ marginBottom: "10px" }}> | |||
| <Row key={index} style={{ marginBottom: "10px" }} className={(element.content.props.uiSchema["ui:widget"] === "hidden")?"d-none":undefined} > | |||
There was a problem hiding this comment.
Hmm, the analogous code in @rjsf/core just says:
When ui:widget is hidden, is element.content equal to null / undefined? I'm trying to see if we can achieve the same effect without having to explicitly check for ui:widget equal to hidden, such as something like the following:
{element.content && <Row>...</Row>}
There was a problem hiding this comment.
Hi,
element.contentexists for the hidden fields.- The row object contains the hidden input element, and removing the entire row means no hidden input element is included in the form.
|
bump |
7 tasks
epicfaace
added a commit
that referenced
this pull request
Jun 15, 2021
…ss hidden prop to ObjectFieldTemplate (#2405) * material-ui: hide grid for hidden fields Implementations follows the one that already exists for ant design. Closes #1974 * Update test snapshot to latest master * Add comment * Move ui:widget evaluation into core * Add test for hidden in antd * Hide hidden fields in bootstrap Closes #2175 * Improve tests * Remove whitespace for hidden in fluent-ui * Update custom-templates.md Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
When
ui:widgetishidden, add classd-nonetoRowso that the corresponding row is properly hided. This fix is forbootstrap-4, but basically the other themes can also be patched in the same way.Checklist