Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set schema errors to empty to clear schema errors when re-rendered #2123

Closed
wants to merge 3 commits into from

Conversation

saimanoharnethi
Copy link

@saimanoharnethi saimanoharnethi commented Nov 9, 2020

Reasons for making this change

fixes #2102

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@saimanoharnethi saimanoharnethi changed the title Set schema errors to empty to clear then when re-rendered Set schema errors to empty to clear schema errors when re-rendered Nov 14, 2020
Copy link
Collaborator

@newt10 newt10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm! I have tested this and it solves the problem. Probably needs to be rebased before merge.

@newt10
Copy link
Collaborator

newt10 commented Aug 27, 2021

@epicfaace I have reviewed this PR and added my comment above.

Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change @saimanoharnethi, and thanks for reviewing, @newt10 -- one thing is that it would be great if you could add a test that tests the specific issue in #2102 so we can make sure this issue doesn't regress in the future.

@newt10
Copy link
Collaborator

newt10 commented Sep 2, 2021

@epicfaace , I am closing this in favor of #2536 . I have added tests to #2536 to prevent future regressions. Since the author has not gotten a chance to update the PR, we can go ahead with #2536 for addressing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: validation errors stay on screen onSubmit even after fixing the errors.
3 participants