Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic UI SelectWidget Should Support Labels #2040

Closed
wants to merge 2 commits into from

Conversation

amerryma
Copy link

@amerryma amerryma commented Sep 9, 2020

Reasons for making this change

The semantic ui select widget does not allow for labels on the dropdown. Without it, there is no way to tell which field is being edited. Other UI components already do this.

See example here.

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@amerryma amerryma changed the title Select Widget Should Support Label Semantic UI SelectWidget Should Support Labels Sep 9, 2020
Added default
Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you add a snapshot test that uses a label?

@jacqueswho
Copy link
Contributor

@amerryma you do know this is not going to look right? Semantic ui does not use a label for drop down but the select control?
see example form dropdown .

@epicfaace
Copy link
Member

epicfaace commented Feb 7, 2021

@jacqueswho I think #1972 already takes care of this issue, so are you good with closing this PR?

@jacqueswho jacqueswho closed this Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants