-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playground and development environment fixes for Lerna #1642
Merged
Merged
Changes from 27 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
6b64ea3
feat: update build and dev process
chanceaclark 47a4169
Merge branch 'update-playground' of https://github.com/chanceaclark/r…
epicfaace ed7efec
rename react-jsonschema-form to @rjsf/core and rjsf-material-ui to @r…
epicfaace ff2e678
update contributing docs with new setup
epicfaace a11970c
fix core package setup
epicfaace 5f4e945
update netlify config to properly publish playground
epicfaace 68194d5
run bootstrap on CI
epicfaace 0b25167
add types to @rjsf/core and make @rjsf/material-ui work
epicfaace bce81b4
playground: fix arrays / objects not rendering properly on material ui
epicfaace f2d03e2
update mui readme
epicfaace cd57fa3
update docs
epicfaace 029900d
fix netlify config
epicfaace a9475b0
ci: install npm deps such as lerna
epicfaace e49cdd8
switch azure pipelines order
epicfaace b3652cd
fix netlify
epicfaace 74746cb
add --no-bail and --stream
epicfaace d1d283f
debug netlify build
epicfaace bcd06b6
update playground build
epicfaace 3d741ce
fix playground prod build
epicfaace c20de18
update webpack configs for playground
epicfaace 9798a84
build lib file so it can be properly imported
epicfaace 263ac41
fix resolve for webpack prod config
epicfaace 3d87b4d
remove sleep
epicfaace 2aa9509
Add umd build, don't run build:es:lib in dev mode
epicfaace 83e8fc0
Merge branch 'playground-fix-2' of github.com:rjsf-team/react-jsonsch…
epicfaace 28739d7
Add cross-env for windows compatibility
epicfaace 90b1149
fix babel umd config
epicfaace b19c560
add WidgetProps
epicfaace 0f96efb
fix export typings
epicfaace 592f093
fix package name
epicfaace 4124bb1
update doc
epicfaace 9052547
Merge branch 'master' of github.com:rjsf-team/react-jsonschema-form i…
epicfaace a4a2426
add boolean to widgetProps
epicfaace File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
[build] | ||
base = "packages/playground" | ||
publish = "build" | ||
command = "npm run build:playground" | ||
base = "" | ||
publish = "packages/playground/build" | ||
command = "npm run bootstrap && npm run build" | ||
|
||
[build.environment] | ||
SHOW_NETLIFY_BADGE = "true" |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
const BABEL_ENV = process.env.BABEL_ENV; | ||
|
||
const defaultPlugins = [ | ||
'@babel/plugin-proposal-class-properties', | ||
'@babel/plugin-proposal-object-rest-spread', | ||
'@babel/plugin-proposal-optional-chaining', | ||
// IE 11 support | ||
'@babel/plugin-transform-object-assign' | ||
]; | ||
|
||
module.exports = { | ||
presets: [ | ||
[ | ||
"@babel/preset-env", | ||
{ | ||
modules: ["cjs", "test"].includes(BABEL_ENV) ? "commonjs" : false, | ||
targets: | ||
BABEL_ENV === "test" ? { node: "current" } : { browsers: "defaults" }, | ||
}, | ||
], | ||
"@babel/preset-react", | ||
], | ||
env: { | ||
cjs: { | ||
plugins: defaultPlugins, | ||
ignore: ['test/**/*.js'] | ||
}, | ||
umd: { | ||
plugins: defaultPlugins, | ||
ignore: ['test/**/*.js'] | ||
}, | ||
es: { | ||
plugins: [ | ||
...defaultPlugins, | ||
['@babel/plugin-transform-runtime', { useESModules: true, corejs: 2 }] | ||
], | ||
ignore: ['test/**/*.js'] | ||
}, | ||
test: { | ||
plugins: defaultPlugins, | ||
ignore: [] | ||
} | ||
}, | ||
}; |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably don't want to change this. It should be the name of the repo if it's a monorepo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think should be done with the
version
attribute? I don't think Lerna automatically bumped it upon release, and I'm not sure ifversion
is even relevant in the top of the monorepo.