-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for contributing #1639
Conversation
@juliankigwana @Saulzi @chanceaclark let me know if this is clearer or if the docs I've added might need more clarification? |
Yes definitely clarifies things, I will give this workflow a go now |
unfortunately this did not work on #1610 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good
cd packages/playground | ||
npm run build:lib | ||
npm link | ||
cd ../core | ||
npm link @rjsf/playground | ||
npm start | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this should be done when the user pulls the package rather than an additional step otherwise this works for me 👍
this did after install on bottom level and setting back index.js to be import Form, { withTheme } from "@rjsf/core"; in packages/playground on my branch |
Would it be simpler, rather than having each package have its own playground start scripts, to just have each package build their files (as @chanceaclark 's PR in #1606 does)? Then, in order to run the playground, one would just need to This thought came up because I was trying to add the playground to material-ui but realized that doing so would require a lot of overhead for each new package we add. |
Reasons for making this change
Add docs for contributing on a separate page, and also explain the development / deployment process for the new multi-package setup.
Checklist