Introduce Form autoComplete attribute and deprecate autocomplete #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epicfaace
reviewed
Oct 16, 2019
src/components/Form.js
Outdated
| console.warn( | ||
| "Using autocomplete property of Form is deprecated, use autoComplete instead." | ||
| ); | ||
| if (currentAutoComplete) { |
There was a problem hiding this comment.
Thanks! Thanks for the deprecation check. I don't think we need this check to see if both autocomplete and autoComplete are set (because the user will already get the autocomplete deprecation warning from before), so you can probably remove it.
There was a problem hiding this comment.
OK, removed :-)
epicfaace
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
We should rename the
autocompleteattribute on<Form>toautoComplete. This is because that's how React does it on the actual<form>element, so it will be a more familiar attribute name for React developers.If this is related to existing tickets, include links to them as well.
fixes #1156
Checklist