trim empty objects to allow correct validation of optional objects with mandatory fields #1228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
NOT FOR MERGE YET!
Test failures remain - see discussion below.
This PR offers a potential solution for the issue of allowing optional objects with required fields to pass validation when none of their values are defined.
The approach is similar to that discussed in Issue 675 and proposed, then withdrawn, in PR 682.
Prior to validation, a clone of formData is generated where all objects with no defined values are removed (note: empty arrays are not removed).
This works nicely - but changes the semantics of the errors. Primarily 'is a required property' errors become 'should be object'. Currently I have not changed the tests so as to display that.
I have raised this PR to essentially ask whether this approach could be used and, if so, to seek advice on what to about the changed errors (I note the conversation here).
If this is related to existing tickets, include links to them as well:
#675
#682
Checklist
npm run cs-format
on my branch to conform my code to prettier coding style