-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab stop for Add button + #365
Comments
It makes sense not to tab to reorder and remove but add is a very common when filling out a form. |
This sounds good to me, although @n1k0 is the final judge! |
Sounds good to me too. Would you want to work on a patch? |
Sure thing. The trivial fix of removing the tabstop leaves our tab ever so slightly poorly placed on the + button after adding an item. I'll look into a sane solution to that. The ref chasing solution that seems to be common in react land feels terrible but a bit of tabstop number tracking and setting it correctly for the plus after add might do the trick. |
* Update dependencies to their latest versions. (#386) * Fix #385: Avoid dynamic requires. (#387) * Fix #365: Tab stop for Add button + (#392) * Add a single field form example in the playground (#390) * Allow using field names containing a dot character (#397) * Updated eslint config. * Improve checkbox and radio button styles (#403) * Add missing proptype for disabled (#416) * Temporary fix for #349 and facebook/react#7630 radio widget bug (#423)
Released along v0.41.2. |
Prerequisites
Description
When tabbing through a form that contains array schema the cursor does not stop on the plus button.
Also happy to PR this on a thumbs up
Expected behavior
I'd expect the + button to take focus and probably click on spacebar
Actual behavior
It doesn't
Version
0.40.0
The text was updated successfully, but these errors were encountered: