Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playground not rendering the form output #3579

Closed
3 of 4 tasks
kunalshewale opened this issue Apr 5, 2023 · 1 comment
Closed
3 of 4 tasks

Playground not rendering the form output #3579

kunalshewale opened this issue Apr 5, 2023 · 1 comment
Labels
bug

Comments

@kunalshewale
Copy link

kunalshewale commented Apr 5, 2023 •
edited
Loading

Prerequisites

What theme are you using?

antd

Version

5.x

Current Behavior

Playground not rendering the JSON form output. Getting error as Minified React error #130; visit https://reactjs.org/docs/error-decoder.html?invariant=130&args[]=undefined&args[]= for the full message or use the non-minified dev environment for full errors and additional helpful warnings.

image

Expected Behavior

The playground should render the form

Steps To Reproduce

No response

Environment

- OS:
- Node:
- npm:

Anything else?

No response
@kunalshewale kunalshewale added bug needs triage Initial label given, to be assigned correct labels and assigned labels Apr 5, 2023
@kunalshewale kunalshewale changed the title <title> Playground not rendering the form output Apr 5, 2023
@heath-freenome heath-freenome removed the needs triage Initial label given, to be assigned correct labels and assigned label Apr 5, 2023
heath-freenome added a commit to heath-freenome/react-jsonschema-form that referenced this issue Apr 5, 2023
@heath-freenome
fix: Fixes broken playground form display and small mui bug
484f066 
Fixes rjsf-team#3576 and rjsf-team#3579 by only passing `templates` with non-`undefined` values
Fixes rjsf-team#3578 by using `TextField` to render the label key input value

- Updated `@rjsf/material-ui` and `@rjsf/mui` to use the `TextField` as the input for the label key value rather than attempting to cobble one togther
  - Updated the snapshots accordingly
- Updated the `Playground` component to only pass `templates` with values that aren't undefined to the main `Form`
- Updated the `CHANGELOG.md` accordingly
@heath-freenome heath-freenome mentioned this issue Apr 5, 2023
Merged
8 tasks
@mclacore
Copy link

mclacore commented Apr 5, 2023

I've also been having this bug for the last couple days.

heath-freenome added a commit that referenced this issue Apr 5, 2023
@heath-freenome
fix: Fixes broken playground form display and small mui bug (#3583)
3db058f 
Fixes #3576 and #3579 by only passing `templates` with non-`undefined` values
Fixes #3578 by using `TextField` to render the label key input value

- Updated `@rjsf/material-ui` and `@rjsf/mui` to use the `TextField` as the input for the label key value rather than attempting to cobble one togther
  - Updated the snapshots accordingly
- Updated the `Playground` component to only pass `templates` with values that aren't undefined to the main `Form`
- Updated the `CHANGELOG.md` accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kunalshewale @mclacore @heath-freenome