-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playground fails to launch from repo root #3478
Comments
Some additional info. From the build process I'm seeing a lot of messages like this:
|
@RPiAwesomeness Yeah, when the playground was switched to use Vite, that behavior was broken. We probably should remove the root |
Ah, good to know. That method works great for me. Would it be helpful to create a pull request that removes that root script and updates the documentation? I don't have time to work on fixing the root build process as it is right now but I'd love to help out a little where I can. |
@RPiAwesomeness That would be awesome(ness)! |
Hah, clever 😉 If I have time over the weekend I'll throw that up! |
Fixes rjsf-team#3478 and rjsf-team#3520 by updating documentation - Updated the root `package.json` to change `npm start` to documentation about the new process - Updated the `package.json` files to remove the `npm start` script in all packages that had them except for `playground` and `docs` - Added documentation for `getTestValidator()` in `utils`, `validator-ajv6` and `validator-ajv8` to better describe how validator tests work - Same for `schema.test.ts` - Updated the `internals` documentation to switch to using a React ref - Updated the `contributing` documentation to cover the new development process with `Vite` as well as trying to improve the understanding of validator testing - Updated the `CHANGELOG.md` accordingly
Fixes rjsf-team#3478 and rjsf-team#3520 by updating documentation - Updated the root `package.json` to change `npm start` to documentation about the new process - Updated the `package.json` files to remove the `npm start` script in all packages that had them except for `playground` and `docs` - Added `lint-staged`, `cs-check` and `cs-format` in the `docs` directory to format files - Fixed up the `lint-staged`, `cs-check` and `cs-format` rules in the `playground` to simplify the globs for the real content - Added documentation for `getTestValidator()` in `utils`, `validator-ajv6` and `validator-ajv8` to better describe how validator tests work - Same for `schema.test.ts` - Updated the `internals` documentation to switch to using a React ref - Updated the `contributing` documentation to cover the new development process with `Vite` as well as trying to improve the understanding of validator testing - Updated the `CHANGELOG.md` accordingly
Fixes rjsf-team#3478 and rjsf-team#3520 by updating documentation - Updated the root `package.json` to change `npm start` to documentation about the new process - Updated the `package.json` files to remove the `npm start` script in all packages that had them except for `playground` and `docs` - Added `lint-staged`, `cs-check` and `cs-format` in the `docs` directory to format files - Fixed up the `lint-staged`, `cs-check` and `cs-format` rules in the `playground` to simplify the globs for the real content - Added documentation for `getTestValidator()` in `utils`, `validator-ajv6` and `validator-ajv8` to better describe how validator tests work - Same for `schema.test.ts` - Updated the `internals` documentation to switch to using a React ref - Updated the `contributing` documentation to cover the new development process with `Vite` as well as trying to improve the understanding of validator testing - Updated the `CHANGELOG.md` accordingly
Fixes rjsf-team#3478 and rjsf-team#3520 by updating documentation - Updated the root `package.json` to change `npm start` to documentation about the new process - Updated the `package.json` files to remove the `npm start` script in all packages that had them except for `playground` and `docs` - Added `lint-staged`, `cs-check` and `cs-format` in the `docs` directory to format files - Fixed up the `lint-staged`, `cs-check` and `cs-format` rules in the `playground` to simplify the globs for the real content - Added documentation for `getTestValidator()` in `utils`, `validator-ajv6` and `validator-ajv8` to better describe how validator tests work - Same for `schema.test.ts` - Updated the `internals` documentation to switch to using a React ref - Updated the `contributing` documentation to cover the new development process with `Vite` as well as trying to improve the understanding of validator testing - Updated the `CHANGELOG.md` accordingly
Fixes rjsf-team#3478 and rjsf-team#3520 by updating documentation - Updated the root `package.json` to change `npm start` to documentation about the new process - Updated the `package.json` files to remove the `npm start` script in all packages that had them except for `playground` and `docs` - Added `lint-staged`, `cs-check` and `cs-format` in the `docs` directory to format files - Fixed up the `lint-staged`, `cs-check` and `cs-format` rules in the `playground` to simplify the globs for the real content - Added documentation for `getTestValidator()` in `utils`, `validator-ajv6` and `validator-ajv8` to better describe how validator tests work - Same for `schema.test.ts` - Updated the `internals` documentation to switch to using a React ref - Updated the `contributing` documentation to cover the new development process with `Vite` as well as trying to improve the understanding of validator testing - Updated the `semantic-ui/uiSchema` documentation to switch the default for `horizontalButtons` to be true - Updated the `CHANGELOG.md` accordingly
Fixes rjsf-team#3478 and rjsf-team#3520 by updating documentation - Updated the root `package.json` to change `npm start` to documentation about the new process - Updated the `package.json` files to remove the `npm start` script in all packages that had them except for `playground` and `docs` - Added `lint-staged`, `cs-check` and `cs-format` in the `docs` directory to format files - Fixed up the `lint-staged`, `cs-check` and `cs-format` rules in the `playground` to simplify the globs for the real content - Added documentation for `getTestValidator()` in `utils`, `validator-ajv6` and `validator-ajv8` to better describe how validator tests work - Same for `schema.test.ts` - Updated the `internals` documentation to switch to using a React ref - Updated the `contributing` documentation to cover the new development process with `Vite` as well as trying to improve the understanding of validator testing - Updated the `semantic-ui/uiSchema` documentation to switch the default for `horizontalButtons` to be true - Updated the `CHANGELOG.md` accordingly
Fixes #3478 and #3520 by updating documentation - Updated the root `package.json` to change `npm start` to documentation about the new process - Updated the `package.json` files to remove the `npm start` script in all packages that had them except for `playground` and `docs` - Added `lint-staged`, `cs-check` and `cs-format` in the `docs` directory to format files - Fixed up the `lint-staged`, `cs-check` and `cs-format` rules in the `playground` to simplify the globs for the real content - Added documentation for `getTestValidator()` in `utils`, `validator-ajv6` and `validator-ajv8` to better describe how validator tests work - Same for `schema.test.ts` - Updated the `internals` documentation to switch to using a React ref - Updated the `contributing` documentation to cover the new development process with `Vite` as well as trying to improve the understanding of validator testing - Updated the `semantic-ui/uiSchema` documentation to switch the default for `horizontalButtons` to be true - Updated the `CHANGELOG.md` accordingly
Prerequisites
What theme are you using?
core
Version
5.2.0
Current Behavior
Attempting to run
npm start
from the repo root results in a blank screen and a vite error about failing to resolve entry for@rjsf/material-ui
:This is coupled with a lot of errors in the console, resulting a completely unusable playground and an inability to develop a pull request for it.
Launching via
npm start
from thepackages/playground
folder works without trouble but doesn't seem to support live-reloading or any sort of output via console from thepackages/core
library.The output:
Expected Behavior
Running
npm start
launches the playground locally and enables hot-reload without error.Steps To Reproduce
npm run build
npm start
Environment
Anything else?
No response
The text was updated successfully, but these errors were encountered: