Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bootstrap 5 theme #2428

Closed
1 of 3 tasks
wegry opened this issue Jun 18, 2021 · 4 comments
Closed
1 of 3 tasks

Add Bootstrap 5 theme #2428

wegry opened this issue Jun 18, 2021 · 4 comments

Comments

@wegry
Copy link
Contributor

wegry commented Jun 18, 2021

Prerequisites

Description

react-bootstrap is in an early beta to support bootstrap@5. Copying the existing bootstrap 4 package seems like it would be a good way to start the move over. CSS classes are probably the biggest hurdle.

@epicfaace
Copy link
Member

epicfaace commented Jun 18, 2021 via email

@wegry
Copy link
Contributor Author

wegry commented Jun 18, 2021

I was thinking we'd need react-bootstrap@2 and to change class names around bootstrap 5. This codebase already has a different bootstrap 3 / 4 theme (@rjsf/core and @rjsf/bootstrap-4, respectively).

Bootstrap itself changes -> https://getbootstrap.com/docs/5.0/migration/.
React-bootstrap changes -> https://github.com/react-bootstrap/react-bootstrap/blob/master/CHANGELOG.md

@nurikk
Copy link

nurikk commented Jun 26, 2021

bootstrap 4 and 5 are quite backward compatible, I have project with bootsrap5 and rjsf, everything works fine

@wegry wegry mentioned this issue Jul 18, 2021
7 tasks
@camsjams
Copy link

camsjams commented Oct 13, 2021

Yes for the most part rjsf + bootstrap is fine on Bootstrap v4 or v5

@wegry wegry closed this as completed Oct 14, 2021
@nurikk nurikk mentioned this issue Jun 20, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants