-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bootstrap 5 theme #2428
Comments
That's true -- though do you know how drastic the changes are? If it's only
a couple of class changes, would it be possible to maybe have a more
efficient way of creating themes rather than having to copy a theme
codebase for each new version of Bootstrap?
…--
Ashwin Ramaswami
On Fri, Jun 18, 2021 at 7:56 AM Zach Wegrzyniak ***@***.***> wrote:
Prerequisites
- I have read the documentation
<https://react-jsonschema-form.readthedocs.io/>;
- In the case of a bug report, I understand that providing a SSCCE
<http://sscce.org/> example is tremendously useful to the maintainers.
- Ideally, I'm providing a sample JSFiddle
<https://jsfiddle.net/n1k0/f2y3fq7L/6/> or a shared playground link
<https://rjsf-team.github.io/react-jsonschema-form/> demonstrating the
issue.
Description
react-bootstrap is in an early beta to support ***@***.*** Copying the
existing bootstrap 4 package seems like it would be a good way to start the
move over. CSS classes are probably the biggest hurdle.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2428>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM4MX4D2S6SDT3NABIP5ILTTM7BLANCNFSM465UDQKQ>
.
|
I was thinking we'd need react-bootstrap@2 and to change class names around bootstrap 5. This codebase already has a different bootstrap 3 / 4 theme (@rjsf/core and @rjsf/bootstrap-4, respectively). Bootstrap itself changes -> https://getbootstrap.com/docs/5.0/migration/. |
bootstrap 4 and 5 are quite backward compatible, I have project with bootsrap5 and rjsf, everything works fine |
Yes for the most part rjsf + bootstrap is fine on Bootstrap v4 or v5 |
Prerequisites
Description
react-bootstrap
is in an early beta to supportbootstrap@5
. Copying the existing bootstrap 4 package seems like it would be a good way to start the move over. CSS classes are probably the biggest hurdle.The text was updated successfully, but these errors were encountered: