Infinite $ref recursive error via computeDefaults

[dok]

Prerequisites

• I have read the documentation;
• In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.
• Ideally, I'm providing a sample JSFiddle or a shared playground link demonstrating the issue.

Description

I'm able to consistently reproduce a maximum callstack error. Here is an image of the error.

I believe this is due to the utils.computeDefaults method, that recursively follows a $ref.

Steps to Reproduce

Copy and paste these snippets into their respective input fields in the playground.

JSONSchema

{
  "definitions": {
    "node": {
      "type": "object",
      "properties": {
        "name": {
          "type": "string"
        },
        "children": {
          "type": "array",
          "items": {
            "$ref": "#/definitions/node"
          }
        },
        "otherNode": {
          "$ref": "#/definitions/node"
        }
      }
    }
  },
  "type": "object",
  "properties": {
    "tree": {
      "title": "Recursive references",
      "$ref": "#/definitions/node"
    }
  }
}

UISchema

{
  "ui:order": [
    "tree"
  ]
}

FormData

{
  "billing_address": {
    "city": "Babel",
    "state": "Neverland"
  },
  "shipping_address": {
    "street_address": "221B, Baker Street",
    "city": "London",
    "state": "N/A"
  },
  "tree": {
    "name": "root",
    "children": []
  }
}

Expected behavior

I'm not sure what the expected behavior for this type of behavior is. Since the $ref object does not have a .default property, should it exit out of the recursive loop?

Actual behavior

Uncaught RangeError: Maximum call stack size exceeded
    at RegExp.exec (<anonymous>)
    at findSchemaDefinition (utils.js:489)
    at computeDefaults (utils.js:228)
    at utils.js:246
    at Array.reduce (<anonymous>)
    at computeDefaults (utils.js:243)
    at computeDefaults (utils.js:229)
    at utils.js:246
    at Array.reduce (<anonymous>)
    at computeDefaults (utils.js:243)

Version

1.2.0

[glasserc]

This is an old weakness in rjsf. See #557 and #820. In principle it isn't necessary to instantiate the entire schema, but we do at the moment.

[dok]

Thanks for the response @glasserc. Do you see a resolution to #557 anytime in the near future? Would it be possible to scope the issue down to a more manageable task and just focus on the circular reference within computeDefaults?

I'd be happy to help with this if you had a solution in mind!

[crubier]

Gigantic blocker for me.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please leave a comment if this is still an issue for you. Thank you.