Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up miscellaneous code #33

Merged
merged 10 commits into from
Sep 13, 2023
Merged

fix: clean up miscellaneous code #33

merged 10 commits into from
Sep 13, 2023

Conversation

rahulmadnawat
Copy link
Collaborator

@rahulmadnawat rahulmadnawat commented Sep 11, 2023

Changes

  • Removes unnecessary pointers.
  • Changes signature for CommitUriFromVersion().

Tests

  • make test passing
  • relevant integration tests passing

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@af4a5b4). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage        ?   74.45%           
=======================================
  Files           ?       18           
  Lines           ?     2020           
  Branches        ?        0           
=======================================
  Hits            ?     1504           
  Misses          ?      355           
  Partials        ?      161           

@rahulmadnawat rahulmadnawat changed the title fix: clean up miscellaneous code fix: remove unnecessary pointers Sep 11, 2023
@rahulmadnawat rahulmadnawat changed the title fix: remove unnecessary pointers fix: clean up miscellaneous code Sep 11, 2023
@jshiv jshiv merged commit 154985b into rivian:main Sep 13, 2023
@rahulmadnawat rahulmadnawat deleted the miscellaneous-cleanup branch March 26, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants