Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build release binaries with NODE_ENV and VITE_RIVER_API_BASE_URL #61

Merged
merged 1 commit into from
Jun 23, 2024
Merged

build release binaries with NODE_ENV and VITE_RIVER_API_BASE_URL #61

merged 1 commit into from
Jun 23, 2024

Conversation

bgentry
Copy link
Contributor

@bgentry bgentry commented Jun 23, 2024

Fixes #60.

@bgentry bgentry requested a review from brandur June 23, 2024 20:34
@bgentry bgentry force-pushed the bg-fix-prebuilt-binary-build-envs branch 5 times, most recently from 7a04833 to c436db5 Compare June 23, 2024 20:52
@bgentry bgentry force-pushed the bg-fix-prebuilt-binary-build-envs branch from c436db5 to 189ac75 Compare June 23, 2024 20:53
@bgentry
Copy link
Contributor Author

bgentry commented Jun 23, 2024

Merging this to get a fast fix out before more people hit the issue with these binaries.

@bgentry bgentry merged commit f0ea0b3 into master Jun 23, 2024
9 checks passed
@bgentry bgentry deleted the bg-fix-prebuilt-binary-build-envs branch June 23, 2024 20:56
@bgentry bgentry mentioned this pull request Jun 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandur brandur Awaiting requested review from brandur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Frontend Undefined Variable
1 participant
@bgentry