Update golangci-lint to v1.63.4 #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
reviewed
Jan 25, 2025
| @@ -905,12 +905,12 @@ func Exercise[TTx any](ctx context.Context, t *testing.T, | |||
| require.Nil(t, job.AttemptedAt) | |||
| require.Empty(t, job.AttemptedBy) | |||
| require.WithinDuration(t, now, job.CreatedAt, 2*time.Second) | |||
| require.Equal(t, []byte(`{"encoded": "args"}`), job.EncodedArgs) | |||
| require.JSONEq(t, `{"encoded": "args"}`, string(job.EncodedArgs)) | |||
There was a problem hiding this comment.
I can already tell it's going to drive me crazy that they didn't called this JSONEqual to match all the other existing Equal helpers.
brandur
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regular upgrade of golangci-lint along with required fixes. The new version of vet seems to detect potentially leaked context around
workCtx/workCancel. This may or may not matter in practice, but rather than ignore the lint error I fixed it by ensuring it's always called after a failed start or on shutdown after the producers have shut down, which should make it generally a no-op.