Drop sqlc overrides for JobState
#229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is another small one, but I noticed while doing driver work that since we put a layer of abstraction between sqlc and any public-facing APIs, the `JobState*` state constants in sqlc are not really used anymore. Even the `JobState` type is used to infrequently that golfing "River" off the front also does very little. Here, I propose that we just get rid of the sqlc overrides. They're not a big deal, but not having them means less sqlc configuration that needs to be shared around between YAML files, and less opportunity for error there.
|
@bgentry Another small one. Seem okay? |
bgentry
approved these changes
Feb 25, 2024
| river_job_state_discarded: "JobStateDiscarded" | ||
| river_job_state_retryable: "JobStateRetryable" | ||
| river_job_state_running: "JobStateRunning" | ||
| river_job_state_scheduled: "JobStateScheduled" |
There was a problem hiding this comment.
one less thing to have to fix when I get that pending state added soon.
There was a problem hiding this comment.
Yep, totally. Should keep future changes of that sort a bit easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another small one, but I noticed while doing driver work that
since we put a layer of abstraction between sqlc and any public-facing
APIs, the
JobState*state constants in sqlc are not really usedanymore. Even the
JobStatetype is used to infrequently that golfing"River" off the front also does very little.
Here, I propose that we just get rid of the sqlc overrides. They're not
a big deal, but not having them means less sqlc configuration that needs
to be shared around between YAML files, and less opportunity for error
there.