Consolidate on .yaml extension for YAML files
#228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one is extremely minor, but we use the `.yml` extension for GitHub Actions and golangci-lint, and the `.yaml` extension for our sqlc configurations. I find that I occasionally type the full "yaml" when doing a file quick search in places like VSCode, and it's a bit better to have the full `.yaml` extension for that because typing "yml" will find either `.yml` or `.yaml`, but typing "yaml" finds only the latter. Both GitHub Actions and golangci-lint [1] are agnostic to the file extension in use. [1] https://golangci-lint.run/usage/configuration/
|
@bgentry The only good news about these frequent intermittent failures is that they're annoying enough that it's going to make us get pretty serious about fixing them fast, lol. Tiny change here — okay with you? |
bgentry
approved these changes
Feb 25, 2024
|
Ty. |
brandur
added a commit
that referenced
this pull request
Mar 13, 2024
Rendering of the build status badge in the README on GitHub is currently broken because of the change I made in #228 that changed the extension of the CI file from `.yml` to `.yaml`. I didn't realize the filename was in the badge's source path, but it is, and trying to locate `ci.yml` no longer finds anything. Here, a very small change to fix the problem.
bgentry
pushed a commit
that referenced
this pull request
Mar 13, 2024
Rendering of the build status badge in the README on GitHub is currently broken because of the change I made in #228 that changed the extension of the CI file from `.yml` to `.yaml`. I didn't realize the filename was in the badge's source path, but it is, and trying to locate `ci.yml` no longer finds anything. Here, a very small change to fix the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is extremely minor, but we use the
.ymlextension for GitHubActions and golangci-lint, and the
.yamlextension for our sqlcconfigurations. I find that I occasionally type the full "yaml" when
doing a file quick search in places like VSCode, and it's a bit better
to have the full
.yamlextension for that because typing "yml" willfind either
.ymlor.yaml, but typing "yaml" finds only the latter.Both GitHub Actions and golangci-lint [1] are agnostic to the file
extension in use.
[1] https://golangci-lint.run/usage/configuration/