smarter short snooze times #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally, snoozed jobs are set `scheduled` for the future and it's the scheduler's job to set them back to `available` so they can be reworked. Just as with retryable jobs, this isn't friendly for short snooze times so we instead make the job immediately `available` if the snooze time is smaller than the scheduler's run interval. We have an identical behavior for errored/retryable jobs for the same reason.
baa1eaf to
2e09403
Compare
brandur
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, snoozed jobs are set
scheduledfor the future and it's the scheduler's job to set them back toavailableso they can be reworked. Just as with retryable jobs, this isn't friendly for short snooze times so we can instead make the job immediatelyavailableif the snooze time is smaller than the scheduler's run interval.We have an identical behavior for errored/retryable jobs for the same reason.