fix: settings not saving in onboarding (#205)

rivenmedia · Feb 5, 2024 · 2de2f54 · 2de2f54
1 parent 848c79b
commit 2de2f54
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 25 deletions.
diff --git a/frontend/src/routes/settings/content/+page.server.ts b/frontend/src/routes/settings/content/+page.server.ts
@@ -57,17 +57,17 @@ export const actions: Actions = {
 
 			const save = await saveSettings(event.fetch);
 			const load = await loadSettings(event.fetch);
-
-			if (event.url.searchParams.get('onboarding') === 'true') {
-				redirect(302, '/onboarding/4');
-			}
-
-			return message(form, 'Settings saved!');
 		} catch (e) {
 			console.error(e);
 			return message(form, 'Unable to save settings. API is down.', {
 				status: 400
 			});
 		}
+
+		if (event.url.searchParams.get('onboarding') === 'true') {
+			redirect(302, '/onboarding/4');
+		}
+
+		return message(form, 'Settings saved!');
 	}
 };
diff --git a/frontend/src/routes/settings/general/+page.server.ts b/frontend/src/routes/settings/general/+page.server.ts
@@ -56,20 +56,19 @@ export const actions: Actions = {
 					}
 				);
 			}
-
 			const save = await saveSettings(event.fetch);
 			const load = await loadSettings(event.fetch);
-
-			if (event.url.searchParams.get('onboarding') === 'true') {
-				redirect(302, '/onboarding/2');
-			}
-
-			return message(form, 'Settings saved!');
 		} catch (e) {
 			console.error(e);
 			return message(form, 'Unable to save settings. API is down.', {
 				status: 400
 			});
 		}
+
+		if (event.url.searchParams.get('onboarding') === 'true') {
+			redirect(302, '/onboarding/2');
+		}
+
+		return message(form, 'Settings saved!');
 	}
 };
diff --git a/frontend/src/routes/settings/mediaserver/+page.server.ts b/frontend/src/routes/settings/mediaserver/+page.server.ts
@@ -57,17 +57,17 @@ export const actions: Actions = {
 
 			const save = await saveSettings(event.fetch);
 			const load = await loadSettings(event.fetch);
-
-			if (event.url.searchParams.get('onboarding') === 'true') {
-				redirect(302, '/onboarding/3');
-			}
-
-			return message(form, 'Settings saved!');
 		} catch (e) {
 			console.error(e);
 			return message(form, 'Unable to save settings. API is down.', {
 				status: 400
 			});
 		}
+
+		if (event.url.searchParams.get('onboarding') === 'true') {
+			redirect(302, '/onboarding/3');
+		}
+
+		return message(form, 'Settings saved!');
 	}
 };
diff --git a/frontend/src/routes/settings/scrapers/+page.server.ts b/frontend/src/routes/settings/scrapers/+page.server.ts
@@ -57,17 +57,17 @@ export const actions: Actions = {
 
 			const save = await saveSettings(event.fetch);
 			const load = await loadSettings(event.fetch);
-
-			if (event.url.searchParams.get('onboarding') === 'true') {
-				redirect(302, '/?onboarding=true');
-			}
-
-			return message(form, 'Settings saved!');
 		} catch (e) {
 			console.error(e);
 			return message(form, 'Unable to save settings. API is down.', {
 				status: 400
 			});
 		}
+
+		if (event.url.searchParams.get('onboarding') === 'true') {
+			redirect(302, '/?onboarding=true');
+		}
+
+		return message(form, 'Settings saved!');
 	}
 };