Feature/add use rive file hook #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HayesGordon
reviewed
May 27, 2024
src/hooks/useRiveFile.ts
Outdated
| * It sets up a RiveFile based on provided source parameters (URL or ArrayBuffer) and ensures | ||
| * proper cleanup to avoid memory leaks when the component unmounts or inputs change. | ||
| * | ||
| * @param params - Object containing parameters accepted by the Rive file in the rive-js runtime, |
There was a problem hiding this comment.
rive-js runtime? we should remove this from the comments. This still refers to the old runtime
HayesGordon
approved these changes
May 27, 2024
damzobridge
reviewed
May 27, 2024
src/hooks/useRiveFile.ts
Outdated
| * | ||
| * @param params - Object containing parameters accepted by the Rive file in the rive-js runtime, | ||
| * | ||
| * @returns {RiveFile} Contains the active RiveFile instance (`riveFile`). |
There was a problem hiding this comment.
Since we updated the return type for the hook to include status, we should probably change the type here to the RiveFileState type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.