Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "-" to subfields #516

Closed
xhero opened this issue Sep 6, 2017 · 2 comments
Closed

Add "-" to subfields #516

xhero opened this issue Sep 6, 2017 · 2 comments
Assignees
@lpugin @xhero @HirschSt @cgueggi
Labels
Enhancement Source

Comments

@xhero
Copy link
Contributor

xhero commented Sep 6, 2017

Repeatable subfields cannot be deleted, an ideal action is to add a minus button before them.
@xhero xhero added this to the 3.6.12 milestone Sep 6, 2017
@cgueggi
Copy link
Contributor

cgueggi commented Sep 6, 2017

minus button seems a good idea to me

@xhero xhero modified the milestones: 3.6.12, 3.7.0 Sep 26, 2017
@xhero xhero modified the milestones: 3.7.0, 3.7.1 Jan 22, 2018
@lpugin lpugin modified the milestones: 3.7.1, 4.0.1 Jan 30, 2018
@xhero xhero removed this from the 4.0.1 milestone Jan 31, 2018
@cgueggi cgueggi mentioned this issue Feb 1, 2018
Closed
@xhero xhero added this to the 6.0 milestone Nov 12, 2018
@xhero xhero removed this from the 6.0 milestone Jun 24, 2020
@xhero
Copy link
Contributor Author

xhero commented Jul 14, 2021

This is particularly important in tags that have validation, as Muscat will complain if even one is empty.

xhero added a commit that referenced this issue Jul 14, 2021
@xhero
#516 Initial "-" implementation
c506864
xhero added a commit that referenced this issue Jul 14, 2021
@xhero
Merge branch 'develop' into devel-activeadmin-2.0
78c1f7e 
* develop:
  #516 Initial "-" implementation
  Fix #1125 and other translations
xhero added a commit that referenced this issue Aug 2, 2021
@xhero
Merge branch 'develop' into devel-work-experiments
ff80f09 
* develop:
  Add redirect after a login
  #516 Initial "-" implementation
  Fix #1125 and other translations
  Make 856x from holdings searchable
  Fix missing field for sunspot
  Add "external resource" filter in source list
  #1132 Add css
  EXPERIMENTAL source indexer with 1k batch size
  #1132 Add icon to holdings with digital images
  Bump addressable from 2.7.0 to 2.8.0
@xhero xhero closed this as completed in cac09f6 Aug 31, 2021
xhero added a commit that referenced this issue Aug 31, 2021
@xhero
Merge branch 'develop' into devel-activeadmin-2.0
71c59f0 
* develop:
  Fix #516, make sure the + sign is only in the first element
  Show all subtags for 852, remove the partial, it was used for linking but that is done automatically now.
  Fix #1128, properly show errors on select items
  #1128 Add validations
  Fix #1138, implement validation to avoid 787 and 773 pointing to themselves.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lpugin lpugin

@xhero xhero

@HirschSt HirschSt

@cgueggi cgueggi

Labels
Enhancement Source
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lpugin @xhero @HirschSt @cgueggi