Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaders missing for TED, TEC and LEC #1436

Closed
xhero opened this issue Aug 30, 2023 · 3 comments
Closed

Leaders missing for TED, TEC and LEC #1436

xhero opened this issue Aug 30, 2023 · 3 comments
Assignees
Milestone

Comments

@xhero
Copy link
Contributor

xhero commented Aug 30, 2023

These three templates are just ignored in the code, a proposition for a proper leader should be made

@xhero
Copy link
Contributor Author

xhero commented Aug 30, 2023

A proposed list (from me):

edition: cc
composite: pc
source: dm or dd if child
edition_content: cd (cm will never happen!)
libretto_source: tm
libretto_edition:ac
theoretica_source: pm

we miss

libretto_edition_content: ad
theoretica_edition_content: pd

and we need to fix:

libretto_edition: ac if collection, am if single
theoretica_edition: pc if collection, pm if single

Note that Muscat has a bug for edition and libretto edition: instead of properly setting those as collection/single item it counts 773 (!) in the childs (!!) for the child leader. This has to be moved to to the toplevel editions, see if 774s exists, and adapt the leader of those as per table.

EDIT: proposal from JW: https://docs.google.com/document/d/1boHNy1O4yhRMaQNJW6H0etRnuPideC1QaieQKFZwRL0/edit

@jenniferward
Copy link
Contributor

I agree with the above regarding what is missing and what needs to be fixed (highlighted in yellow in the document). I would add that EDT should also differentiate between collection and single.

I went a bit further in the document, after having looked at the MARC description in more detail and comparing that with our templates. In case we want to look at it further.

@lpugin
Copy link
Contributor

lpugin commented Aug 31, 2023

Looks good to me

@xhero xhero closed this as completed in 3b5f07c Sep 26, 2023
xhero added a commit that referenced this issue Sep 27, 2023
* develop:
  Test implementation of MEI for works
  Fix #1436, implement missing leaders, fix existing ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants