-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): const fold Condition
on rewrite_expr
#8209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #8209 +/- ##
==========================================
- Coverage 71.58% 71.57% -0.01%
==========================================
Files 1131 1131
Lines 182816 182817 +1
==========================================
- Hits 130872 130858 -14
- Misses 51944 51959 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ecebc47
to
30e7983
Compare
Hey @jon-chuang, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with |
The tag |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
const fold
Condition
onrewrite_expr
Next step: remove redundant filter?
Checklist For Contributors
./risedev check
(or alias,./risedev c
)Documentation