Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): const fold Condition on rewrite_expr #8209

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

jon-chuang
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

const fold Condition on rewrite_expr

Next step: remove redundant filter?

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR DOES NOT contain user-facing changes.

Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #8209 (09f3303) into main (44e98a3) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8209      +/-   ##
==========================================
- Coverage   71.58%   71.57%   -0.01%     
==========================================
  Files        1131     1131              
  Lines      182816   182817       +1     
==========================================
- Hits       130872   130858      -14     
- Misses      51944    51959      +15     
Flag Coverage Δ
rust 71.57% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/utils/condition.rs 96.40% <100.00%> (+<0.01%) ⬆️
src/batch/src/executor/group_top_n.rs 68.23% <0.00%> (-6.48%) ⬇️
src/batch/src/task/task_execution.rs 51.62% <0.00%> (-0.51%) ⬇️
...rc/storage/hummock_sdk/src/filter_key_extractor.rs 93.63% <0.00%> (-0.26%) ⬇️
src/storage/src/hummock/compactor/mod.rs 80.38% <0.00%> (-0.20%) ⬇️
src/common/src/cache.rs 97.15% <0.00%> (-0.11%) ⬇️
src/common/src/types/ordered_float.rs 31.06% <0.00%> (+0.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2023

Hey @jon-chuang, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with git commit --allow-empty -m "rerun" && git push.

@xiangjinwu xiangjinwu added this pull request to the merge queue Feb 28, 2023
Merged via the queue into main with commit a28f711 Feb 28, 2023
@xiangjinwu xiangjinwu deleted the jon/constant-fold-condition branch February 28, 2023 04:45
@xiangjinwu
Copy link
Contributor

The tag mergify/can-merge is deprecated. Just press on github merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants