-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support exp and refactor pow #7971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 2765 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
1311 | 1 | 1453 | 0 |
Click to see the invalid file list
- src/expr/src/vector_op/exp.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
Codecov Report
@@ Coverage Diff @@
## main #7971 +/- ##
==========================================
- Coverage 71.35% 71.34% -0.01%
==========================================
Files 1120 1121 +1
Lines 180827 180839 +12
==========================================
- Hits 129024 129017 -7
- Misses 51803 51822 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As per the title. Since only float64 is supported, let the cast happen in frontend.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
- [ ] My PR DOES NOT contain user-facing changes.Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note
Support function
exp
. The decimal version is not supported.