-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: workaround a flaky source test #19729
Conversation
still failed... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously I increased sleep to 6s and also add flush
to release-2.1
, but the main-cron for v2.1 still failed in release test. Rerun again it can pass.
Actually I didn't sure where the race condition exist, would appreciate any insight from you.
sleep6s + flush can still fail |
In this run. it takes ~1.2s to receive msg
|
Cannot trigger the failure any more after adding logs.. |
Great, this time it failed it takes 1min14s. And no message consumed at all.
|
Strange. We can see the state table has latest offsets, but no data emited. |
50e760b
to
4465f69
Compare
See here for the analysis. Let's make it not flaky first to avoid troubling others. |
4465f69
to
fa23526
Compare
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This test becomes flaky. e.g., https://buildkite.com/risingwavelabs/pull-request/builds/63945
Probable reason: After #19467,
CREATE SOURCE
returns earlier than before (previously, it will wait for source reader created, i.e., connection established). Now it doesn't wait for that.See also #19681 (comment)
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.