feat(snapshot-backfill): introduce state to snapshot backfill #19720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9 tasks
641fa65 to
a3f0881
Compare
c2868dd to
d5c4a10
Compare
Base automatically changed from
yiming/storage-table-iter-avoid-slice-clone
to
main
December 11, 2024 03:46
5567d22 to
ba717b7
Compare
hzxa21
reviewed
Dec 13, 2024
| if self.streams.is_empty() { | ||
| break Poll::Ready(Ok(None)); | ||
| } | ||
| for (vnode, stream) in &mut self.streams { |
There was a problem hiding this comment.
Will polling the streams in vnode order cause starvation or data skew in downstream? Should we use FuturesUnordered instead?
There was a problem hiding this comment.
Changed to use FuturesUnordered in #19936
ba717b7 to
353a5c9
Compare
353a5c9 to
45a1be4
Compare
8 tasks
45a1be4 to
0fb452c
Compare
8 tasks
2d2947f to
579b264
Compare
0fb452c to
7a48e72
Compare
de3fef3 to
627c55a
Compare
7a48e72 to
0913965
Compare
Base automatically changed from
yiming/snapshot-backfill-vnode-stream
to
main
December 30, 2024 10:53
0913965 to
39b4c1b
Compare
There was a problem hiding this comment.
license-eye has checked 5534 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 2332 | 1 | 3201 | 0 |
Click to see the invalid file list
- src/stream/src/executor/backfill/snapshot_backfill/state.rs
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
43a6729 to
b5d15ae
Compare
8 tasks
b5d15ae to
8ad6a3b
Compare
8ad6a3b to
8b58adc
Compare
kwannoel
reviewed
Jan 7, 2025
kwannoel
reviewed
Jan 7, 2025
kwannoel
reviewed
Jan 7, 2025
3977f66 to
d53453b
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In this PR, we will introduce state to track the progress of snapshot backfill. The progress state table will have the following schema
vnode, which means we track the snapshot backfill progress in per-vnode way.epochis the epoch that thevnodeis currently consuming on. We can assume thatepoch >= snapshot_epoch. Whenepoch == snapshot_epoch, thevnodewill be consuming the snapshot, and whenepoch > snapshot_epoch, thevnodewill be consuming the change log onepoch.row_countis the number of rows that we have consumed in this epoch. Therow_countis measured in per-vnode manner.is_epoch_finishedmeans whether the vnode has finished consuming theepoch.pk...is the current progress of consuming the epoch. When the fields only make sense whenis_epoch_finishedisfalse. Note that thepk...is thepkof the first unconsumed row, rather than thepkof the last consumed row, which is different to the one in arrangement backfill.With the
VnodeStreamimplemented in #19936, we can get the current progress of each vnode before the stream is finished. When barrier is received, we can first drain the buffer, and then usePeekable::peekto get the first unconsumed row, and then save thepkto the backfill progress state.In this PR, we only write the progress state, and only read the state for sanity check. In future PR, we will read the progress state to support recoverable snapshot backfill.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.