Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iceberg): support position delete merge on read with hash join #19656

Merged
merged 5 commits into from
Jan 3, 2025

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented Dec 3, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

In this pr
we support iceberg source position delete merge on read with hash join exec

The basic logic is the same as #19126

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxhZs xxhZs marked this pull request as ready for review December 6, 2024 06:33
@graphite-app graphite-app bot requested a review from a team December 6, 2024 06:55
@chenzl25 chenzl25 self-requested a review December 26, 2024 05:26
@chenzl25
Copy link
Contributor

Please give a brief description to this PR.

Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! To further optimize the performance, we can use broadcast shuffle instead of hash shuffle for hash join.

@xxhZs xxhZs enabled auto-merge January 3, 2025 09:12
@xxhZs xxhZs added this pull request to the merge queue Jan 3, 2025
Merged via the queue into main with commit 972d570 Jan 3, 2025
34 of 35 checks passed
@xxhZs xxhZs deleted the xxh/support-position-del-iceberg branch January 3, 2025 11:03
@chenzl25 chenzl25 mentioned this pull request Jan 7, 2025
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants