Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My fork is 91 commits behind master #1

Merged
merged 91 commits into from
Mar 6, 2020

Conversation

rishabhBudhouliya
Copy link
Owner

JENKINS-xxxxx - summarize pull request in one line

Describe the big picture of your changes here to explain to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, include a link to the issue.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code. If a checkbox or line does not apply to this pull request, delete it. We prefer all checkboxes to be checked before a pull request is merged

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. Delete the items in the list that do not apply

  • Dependency or infrastructure update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Further comments

If this is a relatively large or complex change, start the discussion by explaining why you chose the solution you did and what alternatives you considered.

steven-terrana and others added 30 commits October 17, 2019 13:11
…rrect indentation

Co-Authored-By: Raihaan Shouhell <raihaanhimself@gmail.com>
[JENKINS-57660] Addition of a doCheck validation method for invalid refSpec
Add an additional behaviour that disables the multi candidate
scheduling.

The default behaviour of the git plugin is to check for new changes
and trigger a new build for every tip of every branch.
When working with big repositories, high build times and many
independent branches, this behaviour leads to an unnecessary high
resource consumption.
….java

Co-Authored-By: Raihaan Shouhell <raihaanhimself@gmail.com>
….java

Co-Authored-By: Raihaan Shouhell <raihaanhimself@gmail.com>
….java

Co-Authored-By: Raihaan Shouhell <raihaanhimself@gmail.com>
….java

Co-Authored-By: Mark Waite <mark.earl.waite@gmail.com>
dependabot-preview bot and others added 29 commits February 17, 2020 12:36
I had to read very carefully to detect the syntactic errors in the URL.
The comment helps me see more clearly.
Avoid undue load on any one server for this test.
The jsoup jar file is added to the hpi file as a transitive dependency of
the configuration as code test harness.  The git plugin does not deliver
the configuration as code test harness and so it should not deliver the
dependencies of that test harness either.

We've had issues in the past where other plugins mistakenly depended on
a jar file that the git plugin bundled (like joda-time). Better to avoid
others from depending on a transitive test dependency by not including
the transitive test dependency.

The jsoup jar file was included in git plugin 4.1.0 and 4.1.1.
Earlier versions did not include it.

f3c65cb
added the transitive dependency.
Exclude jsoup from git plugin jpi packaging
compile time errors corrected.
This reverts commit 454397e.
JENKINS-59828: Expand support for the SCM API 2.0 to support tags
Includes tag support for SCM file system
Refspec expansion is handled in another pull request and should
be evaluated separately.
[JENKINS-48625] Restore binding of doCheckUrl methods and add some initial checks
@rishabhBudhouliya rishabhBudhouliya merged commit 2cf858e into rishabhBudhouliya:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants