Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify rs2 values for scmode #382

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Clarify rs2 values for scmode #382

merged 2 commits into from
Sep 27, 2024

Conversation

andresag01
Copy link
Collaborator

No description provided.

@andresag01
Update src/insns/scmode_32bit.adoc
b3b80ec 
Signed-off-by: Andres Amaya Garcia <andres.amaya@codasip.com>
arichardson
arichardson approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other improvement could be to clear the tag on an invalid scmode (i.e. no x/invalid perms and maybe rs2 > 1)? But regardless of that change in semantics this LGTM.

@andresag01 andresag01 mentioned this pull request Sep 27, 2024
Closed
@andresag01
Copy link
Collaborator Author

One other improvement could be to clear the tag on an invalid scmode (i.e. no x/invalid perms and maybe rs2 > 1)? But regardless of that change in semantics this LGTM.

I created another ticket for that suggestion: #384

@andresag01 andresag01 merged commit 7d9f0d2 into riscv:main Sep 27, 2024
3 checks passed
tariqkurd-repo pushed a commit to tariqkurd-repo/riscv-cheri that referenced this pull request Oct 9, 2024
@andresag01 @tariqkurd-repo
Clarify rs2 values for scmode (riscv#382)
cd35657 
Signed-off-by: Andres Amaya Garcia <andres.amaya@codasip.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrehrhardt chrehrhardt chrehrhardt left review comments

@arichardson arichardson arichardson approved these changes

@tariqkurd-repo tariqkurd-repo Awaiting requested review from tariqkurd-repo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andresag01 @arichardson @chrehrhardt