-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow CSRRS/C to read CLEN-wide values #108
Conversation
@PeterRugg: I tried this fix as proposed here. |
Thanks for sorting this! Looks good, and the text is a lot clearer than the previous text. Is it worth adding a note about no write happening, and thus no representable/sealed check happening, when the rs1 index is zero (as discussed in the issue)? It's surely the most sensible interpretation at the moment, but could be worth making it explicit? |
@tariqkurd-repo @PeterRugg : I've made an explicit note about the no-write on CSRRS/CSRRC when rs1=x0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Would be nice to have a note on csrr but not necessarily required in this pr.
@andresag01 just to clarify this, I'm happy for you to rebase-and-merge this now. The note can be added later. |
@Timmmm : Could you please review again and resolve the conversation if you are happy with the changes? Thanks! |
any objections to merging this one? @arichardson maybe you can do the honours |
Fixes #92