Fixed theme #63
Closed
Fixed theme #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initiated the docs-resources submodule as it requires the files locally to find them. Moved the docs-resources to track the main branch of the submodule.
sameo
reviewed
Jan 21, 2024
There was a problem hiding this comment.
Why are we pulling all those images as part of the docs-resources submodule? imho, given that those are spec specific images (IOMMU mostly) they should not be shared with other specs.
There was a problem hiding this comment.
You're correct, they shouldn't be in the docs-resources repo at all. I have to find which spec they belong to and fix this.
There was a problem hiding this comment.
Thanks. I think you need to update the submodule SHA in this PR though.
|
This is fixed with #114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initiated the docs-resources submodule as it requires the files locally to find them.
Moved the docs-resources to track the main branch of the submodule.
Spec will build with theme applied now.