Complete mitigation section #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameo
reviewed
Apr 30, 2024
specification/05-security_model.adoc
Outdated
Comment on lines
445
to
446
| - The TVM must accept the DMA translation table explictely. | ||
| - The TSM must not enable DMA translation table until the TVM accepts it. |
There was a problem hiding this comment.
I don't think the TVM should or can accept the DMA translation tables.
Suggested change
| - The TVM must accept the DMA translation table explictely. | |
| - The TSM must not enable DMA translation table until the TVM accepts it. | |
| - The RDSM must guarantee that a DMA transaction from one TDI is translated by an IOMMU instance controlled by a TSM that manages the TVM to which the TDI is bound to. | |
| - The TSM must guarantee that the DMA translation table for a TDI under its control is consistent with the G-stage tables for the TVM the TDI is bound to. | |
| - The TSM must not enable DMA translation table until the TVM accepts the TDI. |
There was a problem hiding this comment.
Updated. Thanks for the feedback.
I don't think the TVM should or can accept the DMA translation tables.
For GPA->HPA, right, TVM cannot do anything.
But if DMA translation table also has GVA->GPA, then TVM needs to provide input.
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
sameo
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16