ZIR-345: Delete unused keccak circuit; rename keccak2 to keccak #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mars-risc0
approved these changes
Feb 20, 2025
| @@ -1,48 +1,95 @@ | |||
| load("@rules_pkg//pkg:zip.bzl", "pkg_zip") | |||
There was a problem hiding this comment.
the extensive changes in this diff confused me for quite a while until I realized git has simply replaced zirgen/circuit/keccak/BUILD.bazel with zirgen/circuit/keccak2/BUILD.bazel, and nothing has actually changed! Funny
There was a problem hiding this comment.
Yeah, the diff is annoying. I thought about splitting it up into multiple commits, but it'll get squashed down anyway. Complete summary of my process:
- Ran tests on unaltered repo, verified they passed
- Deleted the
/zirgen/circuit/keccakdirectory - Reran tests, noted a bazel issue with the
//zirgen/circuit:circuittarget. Fixed. - Observed the tests passed again
- Renamed the
/zirgen/circuit/keccak2directory tokeccak - Ran "find and replace"
keccak2->keccak - Observed the tests passed again, and it's done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have two versions of the keccak: the "narrow" version,
keccak, and the "wide" version,keccak2. The latter is the one we use in production, while the former is currently unused. Having these two separate implementations side-by-side has caused confusion for a number of external parties, so it seems best to clean this up. The source code for "narrow" keccak will be preserved in the git history, so if we decide we want it down the road we still have it.