ZIR-343: Allow arrays in externs #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mars-risc0
approved these changes
Feb 19, 2025
| @@ -633,6 +638,13 @@ void LoweringImpl::gen(ExternOp ext, ComponentBuilder& cb) { | |||
| } | |||
| return builder.create<ZStruct::PackOp>(ext.getLoc(), ty, fields); | |||
| }) | |||
| .Case<ArrayType>([&](ArrayType ty) { | |||
| llvm::SmallVector<Value> elements; | |||
There was a problem hiding this comment.
You already know how many elements you're going to need, so why not allocate them up front instead of pushing and resizing?
f1067c7 to
9ed9f7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the bigint implementation in the v2 circuit, and resolves an open
TODOin the v2 circuit code.