fix: #161 case, when error not happens

riotkit-org · Jan 18, 2022 · 68ac6fe · 68ac6fe
1 parent 5309da1
commit 68ac6fe
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/bahub/bahub/transports/kubernetes.py b/bahub/bahub/transports/kubernetes.py
@@ -55,17 +55,17 @@ def has_exited_with_success(self) -> bool:
 
         errors = yaml.load(self._process.read_channel(ERROR_CHANNEL), yaml.FullLoader)
 
-        if "details" in errors:
+        if errors and "details" in errors:
             for error in errors['details']['causes']:
                 if "reason" not in error:
                     self._io.error(error['message'])
-                    return True
+                    return False
 
                 if error['reason'] == 'ExitCode' and int(error['message']) > 0:
                     self._io.error(f"Process inside POD exited with status {int(error['message'])}")
-                    return True
+                    return False
 
-        return False
+        return True
 
 
 def pod_exec(pod_name: str, namespace: str, cmd: List[str], io: IO) -> ExecResult: