Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get automated tests working #23

Merged
merged 4 commits into from
Jan 21, 2022
Merged

Get automated tests working #23

merged 4 commits into from
Jan 21, 2022

Conversation

jordan-brough
Copy link
Member

@jordan-brough jordan-brough commented Jan 20, 2022 •
edited
Loading

See individual commits

  • Remove Rails versions < 6. They don't support Ruby 3, and in our branch we've added Ruby 3 to the test matrix.
  • Update Rails 6.0/6.1 versions, which were lagging
  • Remove Ruby 2.5 from test matrix. It's giving me some gem version errors, and it won't be supported for Rails 7.
  • Fix the tests to actually run. Upstreamed at Fix rspec invocation in CircleCI thoughtbot/administrate#2125

@jordan-brough
Remove testing of Rails < 6
8a30165 
Rails versions < 6 do not support Ruby 3.
@jordan-brough jordan-brough changed the title Remove testing of Rails < 6 Remove testing of Rails < 6 and update Rails 6.0/6.1 versions Jan 20, 2022
@jordan-brough jordan-brough force-pushed the rinsed-v1-disable-old-rails branch from f214919 to 2a26082 Compare January 20, 2022 22:04
@jordan-brough jordan-brough force-pushed the rinsed-v1-disable-old-rails branch from 2a26082 to 6ad0c0e Compare January 20, 2022 22:11
@jordan-brough jordan-brough changed the title Remove testing of Rails < 6 and update Rails 6.0/6.1 versions Tests: Remove Rails < 6, update Rails 6.0/6.1 versions, Remove Ruby 2.5 Jan 20, 2022
@jordan-brough
Remove Ruby 2.5 from test matrix
648c010 
It's giving me some gem version errors, and it won't be supported for Rails 7.
@jordan-brough
Fix rspec invocation in CircleCI
db5f2b2 
The tests weren't actually running, only the "bundler:audit" task was.
@jordan-brough jordan-brough force-pushed the rinsed-v1-disable-old-rails branch from 6ad0c0e to db5f2b2 Compare January 20, 2022 22:53
@jordan-brough jordan-brough changed the title Tests: Remove Rails < 6, update Rails 6.0/6.1 versions, Remove Ruby 2.5 Get automated tests working Jan 20, 2022
@jordan-brough jordan-brough merged commit 2b315b3 into rinsed-v1 Jan 21, 2022
@jordan-brough jordan-brough deleted the rinsed-v1-disable-old-rails branch January 21, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhippenmeyer nhippenmeyer nhippenmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordan-brough @nhippenmeyer