Allow the node hostpath to be set from helm chart env var #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, missed the changes in version in the makefile. bumped to 0.2.2 |
|
cool, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I came across your helm chart for hostpath provisioner. It's great. But I have a need to custom set the actual path on the node.
I modified the chart first, and then found it was acting weird(e.g., the chart was setting it correctly, and a directory for the pvc directory was showing up where it should, but nothing was being written to it. After some investigation, I found it was also still using /mnt/hostpath and creating a pvc directory there too! =)
Once I dug into your code in this repo, I saw that it was hard coded here.
I am not sure you were looking to take outside changes, but I thought I would send you the PR in case you don't mind.
This change should not effect your current helm chart as it defaults to what was hard coded.
Also expect a PR for the chart after I send this. That on the other hand is dependent on this change to the code and an updated "latest" docker image.
Kindest Regards!